sindresorhus/refined-github

Extension options are reset when changing site access #2908

jack1142 posted onGitHub

When I change this to "When you click the extension", all my extension options get reset: image


That's nuts. It doesn't seem to happen for https://github.com/fregante/github-issue-link-status (but it uses a slightly older webext-options-sync version)

posted by fregante about 5 years ago

And you've just recommended me another great extension 😄 Yeah, it's really weird but on the plus side for me, I finally found some possible explanation why my token in the extension was disappearing sometimes, I never had anything specific to report so I might have ignored it...

posted by jack1142 about 5 years ago

I finally found some possible explanation why my token in the extension was disappearing sometimes

I definitely like this bug report than a "my data is inexplicably lost" issue, I dread that in my https://github.com/fregante/webext-options-sync/

posted by fregante about 5 years ago

This bug might be related to permissions.onRemoved and the features around GH Enterprise support. Help debugging this would be appreciated.

posted by fregante about 5 years ago

Well, yeah. This removes the permission to github.com and when you do that, Refined GitHub cleans the options for that domain.

https://github.com/sindresorhus/refined-github/blob/7c5745bb4a7db9c07aceff98f54c58bfb3771838/source/options-storage.ts#L74-L80

PR welcome to filter out GitHub from the origins so Storage#remove doesn't run

posted by fregante about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests