sindresorhus/refined-github

CI link next to the repo's title always displays failure. #2884

kublaios posted onGitHub

<img width="400" alt="failed" src="https://user-images.githubusercontent.com/1839554/76539425-0c692e80-6481-11ea-82c9-d6e216c41e23.png">

No matter which branch I am on or what the status of the latest CI job, I always see failure icon which opens a menu where the failure is from a job that is from 3 months ago.

This has been an issue since we had the CI and I had the plugin. The result is the same no matter the plugin has a personal token or not.


That mark is taken from the main brain’s Commits view: /user/repo/commits

How does it look there? The first icon found in the list is shown next to the title.

This icon used to depend on the current branch but recently we just made it stick to the default one.

posted by fregante about 5 years ago

That mark is taken from the main brain’s Commits view: /user/repo/commits

How does it look there? The first icon found in the list is shown next to the title.

Well in my case it's a repo of an Organization so I assume the path should be /organization-name/repo-name/commits? The icon is still the same.

This icon used to depend on the current branch but recently we just made it stick to the default one.

đź‘Ť

posted by kublaios about 5 years ago

The icon is still the same.

Do you mean it’s red on that page?

posted by fregante about 5 years ago

The icon is still the same.

Do you mean it’s red on that page?

Yes, it's the red 'x' icon.

posted by kublaios about 5 years ago

Then the repo is failing and the icon we show is correct.

GitHub has been showing each branch’s status icon for a few months now, so our icon just uses the default branch. If that’s failing, the repo is failing.

posted by fregante about 5 years ago

Then the repo is failing and the icon we show is correct.

GitHub has been showing each branch’s status icon for a few months now, so our icon just uses the default branch. If that’s failing, the repo is failing.

Do you mean that the icon will turn green after a couple of months? A failure from 3 months ago shouldn't mean that the repo is failing the tests.

posted by kublaios about 5 years ago

I also think the current behavior is somewhat unintuitive. Take this repo as an example: https://github.com/samuelmeuli/font-picker. I removed CI one year ago but because the last check was a failure, this is still displayed on the repo page. IMO the check status of the most recent commit should be used and earlier ones should be ignored.

posted by samuelmeuli almost 5 years ago

I removed CI one year ago

That's a separate issue and a valid one. Fixed in #2990

posted by fregante almost 5 years ago

Awesome, thanks @fregante! :)

posted by samuelmeuli almost 5 years ago

Still stuck on a failure that's from 3 months ago... I did a reinstall but it didn't help, also cleared the caches through the extension settings on Firefox. I also re-ran the CI on the failed branch and succeeded, but still displaying the old failure. Is there another way to reset everything?

posted by kublaios almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests