sindresorhus/refined-github

Extension seems to hide assignees menu from issues and PRs #2836

akmadian posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

Refined GitHub seems to be removing or otherwise hiding the assignees menu from issues and PRs. I tried disabling and re-enabling the extension to test it, and it always disapears when enabled, and reappears when disabled.

Oddly, the assignees menu shows, and I can interact with it when there is already someone assigned, but does not show when there is no one assigned.

No assignees (Refined GitHub enabled): no-assignees

With Assignees (Refined GitHub disabled): w-assignees

The same thing happens when viewing a PR.


Forgot to add version info: Browser: Firefox Dev Edition 74.0 OS: Win 10 Pro 1809 Extension: 20.2.19

posted by akmadian about 5 years ago

Empty sections are completely removed if RGH doesn’t think you can edit them. Here either this detection is broke for Assignees, or some other selector needs to be updated

posted by fregante about 5 years ago

I'm not a full member of the Creative Commons org, I'm a collaborator, so maybe that's affecting it? Is there a toggle for this in settings? I love RGH, but I can't use it if there's no way to turn this off :/

posted by akmadian about 5 years ago

This is the clean-sidebar feature you can disable temporarily in the options.

The detection happens in the DOM: if there’s a “settings” icon, then you can edit it, so the section should not be removed.

posted by fregante about 5 years ago

Yep, just found it and was about to comment with the name of the setting. It does have a gear icon on it, so I'm not sure what the deal is.

Do you consider this to be a proper bug that needs fixing? If so, I could investigate further if I can find the time.

posted by akmadian about 5 years ago

Do you consider this to be a proper bug that needs fixing?

Yep, it's a bug, but I can't reproduce it. This is what it looks like for me:

<img width="248" alt="" src="https://user-images.githubusercontent.com/1402241/75522629-627fb000-5a45-11ea-8d28-6b5beb9e8332.png">

If you look into the issue, maybe you can find out why it's not working correctly there.

Extension errors don't appear in the regular console, so use the Browser Console

posted by fregante about 5 years ago

Sounds good, will investigate soon :) It may have to do with my permissions for the CC org as I'm not a member with full perms, but I help maintain a couple repos (the repo in screenshots is one of them).

posted by akmadian about 5 years ago

@fregante wasn't this fixed?

posted by yakov116 almost 5 years ago

@yakov116 thanks! I forgot to close it in https://github.com/sindresorhus/refined-github/pull/2916

posted by fregante almost 5 years ago

I'm still having this issue Firefox 85.0.2 (64-bit), addon version 21.2.9. When there is actually someone assigned, it's visible however.

posted by Visne about 4 years ago

Fund this Issue

$0.00
Funded

Pull requests