sindresorhus/refined-github

Notifications Beta: `mark-unread` is not compatible #2801

fregante posted onGitHub

The notifications UI is completely different, so that mark-unread part needs to be rewritten. Maybe not right now, but definitely when Notifications leaves Beta


Hi @fregante. I no longer see Mark as unread button on the issue page. I guess this issue about Notification page, right?

posted by ilyam8 about 5 years ago

@ilyam8 are you on 20.2.14.922? #2796

posted by fregante about 5 years ago

Yes, i use Chrome, 20.2.14.922 is latest in the web store.

ok. i see https://github.com/sindresorhus/refined-github/issues/2796#issuecomment-587428669, thx đź‘Ť

posted by ilyam8 about 5 years ago

@fregante doesn't "Mark as unread" now feel the same as "Save"? It would make more sense because the user is essentially saving an issue/PR to get back to sometime later. Except we do that even if there is no notification for that issue/PR and the user doesn't have to subscribed for it in the first place to save it, same as bookmarking.

Well we can't call that any of these because GitHub already uses the same wording. Maybe "Save for later", and show these in the "Saved" notifications view?

Also worth mentioning that this only makes sense if the user has "Group by repositories" applied; as the default "Group by date" view (for both "Saved" and "Repository level notifications") is paginated with a count at the bottom.

posted by notlmn almost 5 years ago

I’m not sure of what you’re talking about.

GitHub’s Mark as unread hasn’t changed behavior. Refined GitHub’s Mark as unread matched its behavior exactly, except that instead of remaining as “read” notification, it would just disappear.

Neither one of them ever worked as “Save” — which is an additional, unrelated list that doesn’t expire, even if marked as Done; "Saved" notifications are basically bookmarks.

posted by fregante almost 5 years ago

I was trying to say that our "Mark as read" worked as GH's "Save" (kinda), and should probably work that way if implemented?

posted by notlmn almost 5 years ago

That would change the feature and I don’t see a reason to. If you need to Save something, create a bookmark, it’s way more flexible.

posted by fregante almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests