The issue has been closed
- Browser: Firefox 72
- Refined GitHub version: 20.2.14
Since GitHub displays issue counts above 5,000 as "5,000+", it seems Refined GitHub fails to parse this and displays "NaN" instead. It should probably be changed to subtract the number of bugs from 5,000 and display a trailing + to indicate the number of issues is approximate. This happens on https://github.com/godotengine/godot, specifically.
I didnāt anticipate that. š
But
- if thereās a total of 7001 issues of which 2000 are bugs, the tab should still display 5000+
So we shouldnāt touch the counter, but:
- if thereās a total of 5001 issues of which 4000 are bugs, now it looks like there are 9001 issues
š¤·āāļø A solution would be to also count non-bug issues in the same query.
Alternatively, yeah, we should should show 3000+ in the first case and 1000+ in the second
This is an issue for repositories which do not have + in the total as well. I'm seeing NaN for the total for this repository as well. (addon is disabled for this screenshot to show the unaltered view)
We need to use:
counter.textContent = Number(counter.textContent.replace(/\D/g, '') - bugsCount;
And also this shows me we need to add a thousands separator on both numbers. I think the Intl object lets us do this easily
@fregante This also happens on repos with over 1000 open issues, due to the ,.
Please see: https://github.com/typeorm/typeorm
<img width="542" alt="Screen Shot 2020-02-19 at 4 04 56 pm" src="https://user-images.githubusercontent.com/1523286/74803650-d0372800-5331-11ea-93b3-2930fff3e12b.png">
Quite like this feature, I've submitted a first attempt at a fix, based on the conversation here. :)
IssueHunt