sindresorhus/refined-github

Draft PR icon looks weird #2755

Jamesking56 posted onGitHub

<!-- Thanks for reporting a bug! ⛰ 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

The Draft PR icon (changed in #2742) looks really strange and doesn't resemble anything.

image

I'm using Brave Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit) on Ubuntu 18.04 LTS


That's really interesting. If lighter, but there's a small artifact near the arrow that kinds ruins it.

<img src="https://user-images.githubusercontent.com/1402241/74149878-c7fd2f80-4c43-11ea-8853-cf0e110c7f79.png">

posted by fregante about 5 years ago

Actually it's not an artifact, it's just the stroke of the arrow's head touching the arrow's body, but it looks ugly 😰

posted by fregante about 5 years ago

We can also make the stroke thinner and use an even darker color instead:

.js-issue-row [aria-label="Open draft pull request"] svg {
  stroke: #24292e; /* ← $gray-900 from https://primer.style/css/utilities/colors */
  stroke-width: 1.2px; /* ← */
  color: #fff !important;
  paint-order: stroke;
  overflow: visible !important;
}

Screenshot_2020-02-13_15-09-52

posted by FloEdelmann about 5 years ago

^ Just tried this myself and it does look a lot better for me.

The only thing I would do is change the colour to be a lighter grey as it looks almost black which to me doesn't signify a draft PR.

posted by Jamesking56 about 5 years ago

Please send a PR with that CSS. I just used that style in for a different feature and it looks great!

posted by fregante about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests