sindresorhus/refined-github

See "Last updated" date on Pinned issues #2747

yakov116 posted onGitHub

<!-- Thanks for contributing! 🏓 -->

Example URL: https://github.com/sindresorhus/refined-github/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

<!-- Please specify a URL where the feature should appear -->

I am so used to seeing when the last time an issue was updated (thanks RH 😉), it would be nice to have it on pinned issues. The only time I would want to see it, is if there is a comment. (not a label update etc..)

Draft: image

something like this should do the job

{
  repository(owner: "sindresorhus", name: "refined-github") {
    issue (number:2671){
      comments(last:1) {
          nodes {
            updatedAt
          }
      } 
    }
  }
}

Sounds reasonable. Does GitHub ever show anything else on that line? Like any tags and such

posted by fregante about 5 years ago

@fregante did some spot checking. Not that I noticed.

I updated the query also to look at specifically, what I want to see.

posted by yakov116 about 5 years ago

That wouldn’t match the time that GitHub shows; we’d have to use the issue’s update time, not the last comment’s (which also doesn’t include review comments, as far as I know)

posted by fregante about 5 years ago

@fregante exactly my point. I don't see the need to know when a help wanted label has been added. I wish github had an option sort by last comment added.

I want to know when the last comment was added.

posted by yakov116 about 5 years ago

What if we would write instead of updated, commented?

posted by yakov116 about 5 years ago

My point is that we can't change the how GitHub's regular sorting works so it's best to match its definitions as well. If an issue appears both pinned and at the top of an issue list the user will see 2 different dates, labelled slightly different. We shouldn't do that.

posted by fregante about 5 years ago

@fregante OK..

I started writing a PR. I got so lost with typescript that I sort of gave up :(

posted by yakov116 about 5 years ago

If it works but types give you grief, open a draft PR and ask for help

posted by fregante about 5 years ago

@fregante will do

posted by yakov116 about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests