Don't auto turn on new features #2743

Why?

Most recent one was updating pr title, which updates PR title when they are merged, which I didn't expect. What we can do is show a page when the extension updates with new features, so user can choose which features they want to turn on.

I tried looking back that feature was added waaaaay back

https://github.com/sindresorhus/refined-github/blob/d747ed5c2f550435a908150b41f4bb3b6cb53b50/src/features/fix-squash-and-merge-title.js it goes back even farther...

Regarding new features, I strongly disagree. When ever you update an app do you expect them to have all new features disabled?

I agree that enhancements are expected to be on by default and they should be. But things like deleting branches, updating pr titles, etc should at least be informed to the user. I am not talking about squash and merge by the way, it's sync-pr-commit-title https://github.com/sindresorhus/refined-github/blob/master/source/features/sync-pr-commit-title.tsx

@iamsolankiamit that function was just updated to do more.

Lets not get petty.

Regarding new features, I strongly disagree. When ever you update an app do you expect them to have all new features disabled?

But things like deleting branches, updating pr titles, etc should at least be informed to the user.

Looks like these are the only things you have an issue with. Am I correct?

Anything that might affect other contributors, should be informed to user. Visual and other enhancements that only affect the user who installed are fine imo.

@fregante Would sending the user to https://github.com/sindresorhus/refined-github/issues/1137 when such a feature be an option?

Yea, that could help.

Duplicate of https://github.com/sindresorhus/refined-github/issues/2664

I’ll copy it here:

Like you can’t disable new features in any websites, we shouldn’t do it here either. We don’t actually guarantee that features don’t depend on each other and some CSS is injected anyway.

Also what’s “new”? Would an improved feature be considered new? What if infinite-scroll starts working on new pages?

If you don’t want new features, disable the updates and only update when needed. Also https://github.com/sindresorhus/refined-github/pull/2668 can help you see which features are new

But things like deleting branches, updating pr titles, etc should at least be informed to the user.

We do have a notice for the title change and it’s right by the title. It also allows the user to cancel it in-place.

Regarding the branches deletion, we already discussed this when the feature was implemented but we consider it non-destructive because:

• you can undo the deletion with one click right there at any time
• if you have long-standing branches, you should mark them as protected in GitHub. This is something you really should do so a git push can’t delete them either
• finally the feature can be disabled if you really don’t like it while most people can enjoy it by default