sindresorhus/refined-github

"Approve and Merge" button on Comments and/or Files changed page #2702

ypresto posted onGitHub

I frequently write "LGTM!" comment and push Approve button on Files changed page of PR, then redirected to Comments page and then push Merge button. Because that redirection is quite slow, it'd be better if we have Approve and Merge button on Files changed page.

Also, Sometimes I write additional review comments on Comments page before approving. So it's nice to have that button on Comments page too.


This request sounds like the opposite of https://github.com/sindresorhus/refined-github/issues/883

That request was about "Approving from the Conversation tab" and this one is about "Merge from the Files tab"

Neither one is particularly easy to implement, but this is harder: merging a PR means also writing the commit title and message, so to "Approve and merge" we have to ALSO show those two fields inside the review box.

Can't do. It would be too much.


Is your repo set up to require approvals before merging? Because if not, you don't need to Approve and merge: just leave a regular comment and merge from the Conversation tab.

posted by fregante about 5 years ago

merging a PR means also writing the commit title and message,

Off-topic: Maybe I need 1-Click® merge button which uses default title and message; I always don't change them.

posted by ypresto about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests