sindresorhus/refined-github

Reposition `tag-changelog-link` #2699

fregante posted onGitHub

GitHub implemented a more generic (i.e. less efficient) version of tag-changelog-link

<img width="120" alt="" src="https://user-images.githubusercontent.com/1402241/72285036-e8ea5900-3674-11ea-8659-eb17d167d2ab.png">

Their feature is not a strict replacement, but now tag-changelog-link needs to be moved above it (or... alternative solutions welcome)

Test

https://github.com/sindresorhus/refined-github/releases/tag/20.1.6


I won't change it. This feature is visually loaded late, introducing an jump in UI if it were placed before the dropdown. Or we need to reserve the place immediately with some CSS.

posted by jerone about 5 years ago

introducing an jump in UI if it were placed before the dropdown

True.

Or we need to reserve the place immediately with some CSS

That may be possible and wouldn't look terrible.

Alternatively we can reposition their button elsewhere

posted by fregante about 5 years ago

I'm kinda disappointed that they just put the button there. Now we have 3 "compare" links on the page.

<img width="753" alt="" src="https://user-images.githubusercontent.com/1402241/72286338-8777b980-3677-11ea-8259-93a7b0f115ec.png">

posted by fregante about 5 years ago

@fregante #2686

posted by yakov116 about 5 years ago

Now we have 3 "compare" links on the page.

Noted! We might combine them in a future iteration ā€“ but there aren't any plans to as of right now.

GitHub implemented a more generic (i.e. less efficient) version of tag-changelog-link

A little background here if it helpsā€“ we originally spiked out a version that was almost identical to the refined-github version. But when we tested it with some organisations who run different 'release channels/lines' at a time ā€“ it actually made things more confusing for their users. So this was a way to mitigate and make comparing release more 'self serve'.

Ideally, I'd love to see us have better support all-round for different Release workflows (hence my tweet) and it's something I'll be advocating for internally šŸ˜„.

posted by lukehefson about 5 years ago

Yeah I figured that you canā€™t make a solution that makes everyone happy. Extensions have the privilege of making feature that only work for a subset of users.

posted by fregante about 5 years ago

For Refined GitHub: we could also combine this to:


Compare to: master (+7) | previous tag | tag...


However I do like the current ā€œChangelogā€ label.

posted by fregante about 5 years ago

However I do like the current ā€œChangelogā€ label.

For this reason, I suggest we just move our Changelog link above the "Compare" dropdown, that's all.

posted by fregante over 4 years ago

Wait, I thought GitHub was adding this link on releases all along. Damn!

posted by notlmn over 4 years ago

Fund this Issue

$0.00
Funded

Pull requests