sindresorhus/refined-github

Displaying tabs as 4 spaces breaks repos that indent with both tabs and spaces #2661

tbodt posted onGitHub


I also can't figure out how to disable this with custom css. This doesn't work, as the rule is somehow overridden by the tab-size: 4 rule in content.css:

* {
    tab-size: inherit !important;
    -moz-tab-size: inherit !important;
}
posted by tbodt over 5 years ago

Don’t indent with both tabs and spaces, use a linter

posted by fregante over 5 years ago

I'm not the one who's indenting with tabs and spaces. Generally you need to display a tab as 8 spaces to be able to display unknown code correctly (such as anything written by Richard Stallman.)

posted by tbodt over 5 years ago

Whoever wrote it it’s based on a wrong or outdated assumption. Most editors don’t default to 8 chars nowadays.

I’m leaving this issue open if anyone can suggest a better selector to override the tab-size. I think you need to add :root:root to make it stronger

posted by fregante over 5 years ago

Could the selector in content.css be made weaker?

posted by tbodt over 5 years ago

I just checked. The selector is * so it literally can’t be weaker. Your code should work already if you change inherit to 8 and/or use :root * as the selector.

posted by fregante over 5 years ago

Changing inherit to 8 didn't help, but using :root * did. This feels a bit insane though. Could you do something like removing !important or changing * to .blob-code?

posted by tbodt over 5 years ago

Any changes means increasing the specificity of the selector, which helps in no way, it just lengthens it and leads to play wack-a-mole with selectors

posted by fregante over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests