The issue has been closed

CTRL + Enter on approval window does not approve #2654

Jamesking56 posted onGitHub

When approving a PR, entering in your approval comment and pressing CTRL+Enter does not click the 'Approve' button. It clicks the 'Comment' button.

As you can see in the screenshot, the 'Approve' button is primary so looks like it'll be the one clicking upon CTRL+Enter. But this is not the case.

Correct, that’s the default action even without Refined GitHub (unless you change the checkbox). There are three choices, we can’t assume you mean “Approve” so we default to the least destructive one. If you change your mind you can then Approve the PR in a second “review”

posted by fregante over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

CTRL + Enter on approval window does not approve #2654

Company

Community

Support

Connect