Editing an issue sometimes shows me old data #2621

For reference, here's the correct version (ie, the version that i expected to have at the end):

# Concept and estimation

### Add Tour to Sales Order, Shipment Candidates, Shipment Document and persist/carryover 

- 5h

### The tour shall be shown on "Rüstschein" (see sales order action and on the sales order document

Note: it's a different process name:
![image](https://user-images.githubusercontent.com/4482210/70685401-f39a8280-1cb1-11ea-9bb3-ce7666d1ca32.png) <- this is where i edited (replaced the photo) !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!


- ???h

### Create process in Shipment Window which allows multiselect shipments and adds them to a Transportation Order

- Q: How shold we handle Shipments which already have a package in a different Transportation Order?
    - A: Quick Solution. Add a virtual column flag in shipment that indicates if a shipment is already integrated into a transportation order. This way the user can see it.Besides that no further functionality needed atm. <- and also this is where i edited (added this line) !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

- probably must call `de.metas.shipper.gateway.commons.ShipperGatewayFacade#createAndSendDeliveryOrdersForPackages` in order to generate the shipment documents (and web-request the shipper)
    - which is called by de.metas.handlingunits.shipmentschedule.api.HUShippingFacade#generateShippingDocuments, but this has multiple roles:
        - receives shipment candidates
        - creates the shipments from candidates
            - ❗️ Q: this should not be done
                - i think i need to add a flag here to disable this (must talk with @metas-ts ❗️ )
        - creates the packages and attaches them to transportation order
        - create the invoices
            - ❗️ Q: should this be done?
        - calls the Shipper to get the PDF data
    - est: 8h
- testing: 4h - maybe more since this touches the Shipper and Shipper Transportation flows, so i don't want to break those



### Transportation Order: Have an action that allows to print out all shipment documents at once that are in the transportation order. New browser Tab opens and shows a PDF which has all Shipment documents. The user cann do print and select the amount of copies before.

> The user cann do print and select the amount of copies before.
Q: What do you mean by this?

- Create test data 
    - 2h
- Try and use something similar to
    - de.metas.dunning.process.C_DunningDoc_JasperWithInvoicePDFsStrategy#executeReport
    - de.metas.invoice.process.C_Invoice_SalesInvoiceJasperWithAttachedDocumentsStrategy#executeReport
    - de.metas.printing.process.ConcatenatePdfs#doIt
    - 6h
- Testing
    - 3h

Total estimation: 5+?+8+4+2+6+3=28h + ??
Used: 7.5h

Milestone does not change from 2019-12-17.

This is unlikely to be Refined GitHub's fault since the only related feature is edit-comments-faster, which simply copies the .js-comment-edit-button class to have GitHub listen to it exactly like it listens to its native Edit button in the dropdown.

<details> <summary>This is GitHub's code connected to it</summary>

p("click", ".js-comment-edit-button", (function(e) {
const t = g(e.currentTarget, ".js-comment");
t.classList.add("is-comment-editing"),
y(t, ".js-write-tab").click();
const n = y(t, ".js-comment-field");
if (!(n instanceof HTMLTextAreaElement))
throw new Error("invariant: app/assets/modules/github/behaviors/commenting/edit.js:20");
n.focus(),
A(n, "change");
const s = e.currentTarget.closest(".js-dropdown-details");
s && s.removeAttribute("open")
}
)),

</details>

Other than this, normally GitHub will warn you if you edit an old comment and try to save it (actually it just discards what you just wrote 🤦‍♂️ and loads their newest version). This is probably done via the timestamp hidden field, which is then compared with the remote version to see if it's newer.

So if this is really happening without warning, your DOM includes the latest version of the comment (and related timestamp) but something is replacing/restoring the textarea content with the old content before you edit it.

I don't think we have any feature that does that.

What browser are you using? Could this be related to you opening/editing the comment in multiple tabs?

Browser: Firefox 71.0 (64-bit). I only have a single tab with that issue. I'm always ctrl+f5 refreshing before editing anything (so that i also catch what my coleagues may edit).

From what i remember, github never warns me that i am editing a stale version because i am not editing a stale one: after refresing the page i see the correct text (ie. the latest revision of a comment, as shown by the revision history) but only when editing the issue i see the old text.

This is sadly not very actionable and hard to reproduce. We can't do anything about it unless someone adds steps to reproduce it