IssueHuntsindresorhus/refined-github
The issue has been closed
Leave PR comments outside 3-lines window around changed lines #2588
zbstof posted onGitHub
Github does not allow me to leave a comment on the lines that are more than 3 lines away from any changed line.
But sometimes I notice some discrepancy elsewhere that I would like to discuss or the place where I would like to suggest a change is more than 3 lines away - method signature for example. Currently I have 3 options as I see it:
- Leave a comment on pull request itself and lose the context
- Add comment on the line that is actually changed and refer to the line number I want to actually discuss - this also loses context and introduces noise (for example I want to leave another comment about the actual line that's changed)
- Go to
View file->Git Blame-> Find the line in question -> Go to latest commit -> Find the line in question ->Add single comment. This is long-winded way of achieving simple goal, don't you think?
Why we cannot leave comments everywhere? 3-lines limit seems arbitrary. Would be nice addition to refined github.
I know that potential benefit of the limit is that we want to keep our PR straight to the point and no introduce unrelated changes, but I would leave it to the team to enforce that, not to the code review tool.
Example URL: https://github.com/octocat/Spoon-Knife/pull/3/files
