sindresorhus/refined-github

Comment edit icon hides in the dots menu after you react to a comment #2572

tunnckoCore posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

  1. yes, it's Refined GitHub
  2. Happens in all repos
  3. screenshots below

before

image

after

image


Other features also affected by this:

  • show-names
  • shorten-links
  • reaction-avatars (... strange, I thought I fixed this in #2533!)
posted by fregante over 5 years ago

@fregante

https://github.com/sindresorhus/refined-github/blob/073b65379a8e5f6a6cb1597b2339416d30a25686/source/libs/on-new-comments.ts#L44

Adding subtree: true will work it would also fix #2852

Is this a good idea or allowing it to run on subtree is too much?

To give you an example, clicking the add reaction button will fire edit-comments-faster 8 times

posted by yakov116 almost 5 years ago

subtree isn't allowed, our events needs to be specific, I don't want to listen to every change on the page.

posted by fregante almost 5 years ago

Any other idea's?

posted by yakov116 almost 5 years ago

https://github.com/sindresorhus/refined-github/blob/073b65379a8e5f6a6cb1597b2339416d30a25686/source/libs/on-updatable-content-update.ts is my last attempt at handling ajaxed contentainers, but I'm not sure if would work in this case.

Ideas come from looking for events in GitHub's code. Sometimes we use those events to start observing new elements.

posted by fregante almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests