The issue has been closed

`remove-diff-signs` not active inside markdown #2569

sarpik posted onGitHub

I'm not sure if this is the expected behaviour, but the diff (+-) signs are shown inside markdown, for example inside README's or issue/PR descriptions/comments etc.

README's
Sample pr description: https://github.com/sindresorhus/refined-github/pull/1866
here:

- the +- signs
+ seem to be showing up here

And once you copy the selection, they're not removed.

Yeah we decided to leave those visible to make people realize they’re copy-pastable

https://github.com/sindresorhus/refined-github/pull/1866#issuecomment-475528334

posted by fregante over 5 years ago

Oh I missed that comment, sorry.

I don't think people would realize they could still copy-paste it and use it as a .diff with Git if they don't see the + and -.

Yeah that makes sense since it's a diff.

I'd love a feature from github where you could select whether or not you want the +- signs to appear, but that's outside the scope of this extension:D

Thank you!

posted by sarpik over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

`remove-diff-signs` not active inside markdown #2569

Company

Community

Support

Connect