The issue has been closed

Notifications beta: Mark as Done, and Save #2546

danielcompton posted onGitHub

The GitHub Notifications beta introduces a new inbox metaphor for notifications. There is also a new "Done" state that a notification can be in. You can manage this from within the notifications view, but if you are in "normal" GitHub, then there is no way to mark a notification as "Done".

Example URL:

Any issue or PR page, e.g. https://github.com/technomancy/leiningen/issues/2566.

For example (but with full-width buttons):

Can you try something for me? What happens when you have a notifications and then you open the issue in "normal" GitHub? Doesn't that automatically mark it as "done"?

Also it's probably best to suggest this to GitHub themselves since it's still in beta. We'd all love an always-visible Save button that replaces our "Mark as read" (which will be completely broken once the new notifications are out of beta)

posted by fregante about 5 years ago

What happens when you have a notifications and then you open the issue in "normal" GitHub? Doesn't that automatically mark it as "done"?

I checked, the notification is marked as Read like before, but not as Done.

As for this feature, we can't display any of those buttons unless there's a notification for it and we know its Notification ID.

There's no API to find out, unless we list ALL the notifications, maybe over multiple pages, API v3 only. This would need to happen for every single issue you open.

Plus we need to fetch the Authenticity token from the form in /notification.

I don't think they're worth all this extra traffic, if you want them it's best to ask GitHub (who are hopefully already looking into it. cc @lukehefson)

posted by fregante about 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Notifications beta: Mark as Done, and Save #2546

Company

Community

Support

Connect