Console Errors #2530

Once this is merged, we can update our dependency: https://github.com/Mottie/github-reserved-names/pull/8. This will fix the first two. The gist error needs a different fix.

@busches it was

Fix for the last one: embed-gist-via-iframe needs to be limited to actual gists:

Ok: https://gist.github.com/yakov116/2d81580f7907839f9065e670f0aba64c Not ok: https://gist.github.com/yakov116

cc @kidonng

The second one is due to close-out-of-view-modals. It could probably be fixed by excluding "fixed" modals like that one.

Fix for the last one: embed-gist-via-iframe needs to be limited to actual gists:

Ok: https://gist.github.com/yakov116/2d81580f7907839f9065e670f0aba64c Not ok: https://gist.github.com/yakov116

cc @kidonng

Roger that. Should I create some isSingleGist function like previous isSingleHTMLFile or check target element existence 😅？

That or create gistList and exclude it on those pages.

On Tue, Nov 12, 2019, 10:07 AM Kid notifications@github.com wrote:

Fix for the last one: embed-gist-via-iframe needs to be limited to actual gists:

Ok: https://gist.github.com/yakov116/2d81580f7907839f9065e670f0aba64c Not ok: https://gist.github.com/yakov116

cc @kidonng https://github.com/kidonng

Roger that. Should I create some isSingleGist function like previous isSingleHTMLFile`😅？

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sindresorhus/refined-github/issues/2530?email_source=notifications&email_token=AAGRMZG4VPFFDB2WFIAMTJDQTLIFTA5CNFSM4JL2T2ZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED2YNBI#issuecomment-552961669, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGRMZBZEKYRCIXEMVOJEOLQTLIFTANCNFSM4JL2T2ZA .

Errors on Sponsor pages (e.g. https://github.com/sponsors/sindresorhus), as of 19.12.2 on Firefox:

❌ toggle-files-button features.tsx:77:16
TypeError: "Argument 1 of MutationObserver.observe is not an object."
    observeElement simplified-element-observer.ts:7
    toggle_files_button_init toggle-files-button.tsx:18
    features_run features.tsx:72
    add features.tsx:123
    onAjaxedPages features.tsx:25
    onAjaxedPagesRaw features.tsx:20

❌ hide-zero-packages features.tsx:77:16
TypeError: "undefined has no properties"
    hide_zero_packages_init hide-zero-packages.tsx:6
    features_run features.tsx:72
    add features.tsx:123
    onAjaxedPages features.tsx:25
    onAjaxedPagesRaw features.tsx:20

❌ forked-to features.tsx:77:16
TypeError: "select_dom_default(...)(...) is null"
    forked_to_init forked-to.tsx:47
    features_run features.tsx:72
    add features.tsx:123
    onAjaxedPages features.tsx:25
    onAjaxedPagesRaw features.tsx:20

❌ more-dropdown features.tsx:77:16
TypeError: "parent is null"
    appendBefore dom-utils.ts:34
    createDropdown more-dropdown.tsx:13
    more_dropdown_init more-dropdown.tsx:22
Will fetch https://api.github.com/repos/sponsors/sindresorhus api.ts:57:12

❌ repo-age features.tsx:77:16
Error: "GraphQL:
Could not resolve to a User with the username 'sponsors'."
    RefinedGitHubAPIError api.ts:31
    v4 api.ts:113

❌ edit-files-faster features.tsx:77:16
Error: "Unable to fetch.
Ensure that your token has access to this repo.
{
    "message": "Not Found",
    "documentation_url": "https://developer.github.com/v3/repos/#get"
}"
    RefinedGitHubAPIError api.ts:31
    getError api.ts:133

Consider making a new page rule for /sponsor?

We need to bump this dependency and they should go away. https://github.com/sindresorhus/refined-github/issues/2530#issuecomment-552708515

Anyone can submit the PR, I've been a bit busy lately.