sindresorhus/refined-github

New Issue editor toolbar cuts out buttons, like "Add a link", "Insert code", and more #2428

archon810 posted onGitHub

Love the extension but this has been bothering me ever since I installed it. Some editor buttons end up missing - and a different set is missing in different cases.

New Issue without extension: image

New Issue with extension: image

As you can see, on New Issue pages, the link, insert code, and a few other buttons are missing. However, they're present in the Leave a comment UI and a different set of buttons is missing there.

Add a comment without extension: image

Add a comment with extension: image

Why is this happening and can it be fixed?

Thanks.


image

Disable this option

posted by yakov116 over 5 years ago

Why is this happening and can it be fixed?

It's happening because all those buttons can be replicated via keyboard shortcuts, you don't need to press those buttons.

posted by fregante over 5 years ago

Thanks. Can we have a discussion about:

  • Why some of those are considered unnecessary, especially the Add link button? (edit: typed this before seeing the answer above)
  • Why the sets of what's hidden differ between New Issue and Add a comment?
posted by archon810 over 5 years ago

By the way, https://user-images.githubusercontent.com/1402241/53629083-a4fe8900-3c47-11e9-8211-bfe2d254ffcb.png, which is the image used by https://github.com/sindresorhus/refined-github/blob/master/source/features/clean-rich-text-editor.tsx, actually shows these buttons as still being there, while in fact they're removed in the New Issue UI, so I believe the real issue is it's removing the wrong buttons: image

posted by archon810 over 5 years ago

while in fact they're removed in the New Issue UI, so I believe the real issue is it's removing the wrong buttons: image

Ouch, indeed!

posted by fregante over 5 years ago

This is broken again.

Issue page ❌

<img width="756" alt="Screenshot 2019-11-12 at 13 47 20" src="https://user-images.githubusercontent.com/1402241/68648504-1cb0e180-0553-11ea-80de-44ac708a4e69.png">

Open PR ✅

<img width="756" alt="Screenshot 2019-11-12 at 13 47 45" src="https://user-images.githubusercontent.com/1402241/68648607-55e95180-0553-11ea-83fc-9a0051d80406.png">

Closed PR ✅

<img width="756" alt="Screenshot 2019-11-12 at 13 47 26" src="https://user-images.githubusercontent.com/1402241/68648528-2df9ee00-0553-11ea-81f3-26832085870f.png"> cc @arnaudvalle

posted by fregante over 5 years ago

As a solution, we should drop the markdown-toolbar > :nth-last-child lines altogether and target the button specifically, like we do for md-mention and md-ref. The downside is that there will be extra spacing in some cases but that's much better than hidden useful buttons.

posted by fregante over 5 years ago

Hello there - I'll have a look at it in the next few days

posted by arnaudvalle over 5 years ago

@fregante Ah well too fast for me :) Thanks for sorting it out 👍

posted by arnaudvalle over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests