sindresorhus/refined-github

Code is getting indented extra due to `indented-code-wrapping` #2421

danawillow posted onGitHub

<!-- Thanks for reporting a bug! â›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed -->

URL: https://github.com/terraform-providers/terraform-provider-google-beta/pull/1116/files#diff-1ae139f5fb2f3b78fda661a248925628 Screenshot: oNnZZYmXgn5

On version 19.9.8


Ouch, I suppose you're on Chrome because it works correctly on Firefox.

You can disable indented-code-wrapping until this issue gets solved

posted by fregante over 5 years ago

Yup, Chrome indeed. Thanks for the workaround!

posted by danawillow over 5 years ago

Hey @danawillow, I'm at RGH 19.9.8 running stable Chrome 76 on Windows 10 1903, and I'm not able to see any glitches like that in either split or unified diffs.

image

Can you mention the exact steps you went through to end up at the situation, it helps a lot for me to debug this thing. And also can I know the exact version and channel of Chrome you are running this on...?

Thanks!

posted by notlmn over 5 years ago

I think both of us are on macOS, it may be font-related

posted by fregante over 5 years ago

FWIW I'm on linux and am having the same experience. Disabling indented-code-wrapping also works for me.

posted by dfawley over 5 years ago

Same problem here on a Mac. This started showing up about a week ago. (same workaround works)

posted by Enrico2 over 5 years ago

May be helpful, based on https://github.com/sindresorhus/refined-github/pull/2436/files

macOS Mojave 10.14.6 Chrome 77.0.3865.75 Font Menlo

<details> <summary>Doesn't work ✖</summary>

gh-mac

</details>


Windows 10 build 1903 Chrome 77.0.3865.75 Font Consolas

<details> <summary>Works ✔</summary>

gh-win

</details>


Arch Linux 5.2.14 Chromium 77.0.3865.75 Font Liberation Mono

<details> <summary>Doesn't work ✖</summary>

gh-lin

</details>

posted by KubaJastrz over 5 years ago

@fregante

the code wrap can also done by adding .soft-wrap class to #discussion_bucket element

posted by muescha over 5 years ago

Not sure if this is helpful but I think text-indent has some problems with tabs. For me the feature works in repositories using spaces instead of tabs.

I can also replicate this issue in a jsbin. I also included an hack with replacing the tabs with spaces.

On Arch Linux 5.3.7 this looks like this for me

<details> <summary>Chromium 78.0</summary>

image

</details>

Interestingly in Firefox it is just a bit to short :sweat_smile:

<details> <summary>Firefox 71.0</summary>

image

</details>

posted by dertieran over 5 years ago
posted by fregante about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests