sindresorhus/refined-github

`releases-tab` does not work without `more-dropdown` #2361

sharkykh posted onGitHub

When more-dropdown is disabled or have failed to initialize due to an error, releases-tab fails to inject. It's not really a bug, but rather an enhancement request - to make releases-tab isolated.

more-dropdown enabled + releases-tab enabled: image

more-dropdown disabled + releases-tab enabled: image

Error in console:

āŒ releases-tab
content.js:2709 TypeError: Cannot read property 'before' of null
    at releases_tab_init (content.js:3509)
    at async features_run (content.js:2704)

It seems that we can't isolate releases-tab because we need to place it after all buttons but before the dropdown. So a dirty check is inevitable.

posted by kidonng over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests