sindresorhus/refined-github

Bug: "More" dropdown always expanded #2357

corysimmons posted onGitHub

Update:

NOTE: A new version (19.8.21) has already been released, please restart your browser and wait for the plugin to update. For Chrome users, you can go to chrome://extensions/, toggle on "developer mode" on the top right corner, and click the "Update" button to immediately receive the update.

Original issue below:

Refined GitHub enabled on Chrome:

image

Disabled:

image

It just started today, and I've only noticed it does this when viewing a Repo (not other views afaik).

Clicking the dropdown, or anything, doesn't hide the dropdown. Seems like it's just stuck in this state.


It just started today, and I've only noticed it does this when viewing a Repo (not other views afaik).

Also happens in pull requests and is overlaying the file tab and branch name, which is quite unfortunate:

<img width="352" alt="fix__some_dependencies_by_joscha_ยท_Pull_Request__64857_ยท_Canva_canva" src="https://user-images.githubusercontent.com/188038/63393924-a8a5e800-c400-11e9-91b1-f3267f830995.png">

posted by joscha over 5 years ago

Not a fix for the issue, but disabling more-dropdown removes this while it is being fixed.

posted by Nightfirecat over 5 years ago

For anyone having trouble, you can find more-dropdown in the extension's settings. For chrome, just right click on the extension(refined github in this case) and click on options. Once there, just scroll down and you will find more-dropdown as Nightfirecat mentioned.

posted by rohitkrishna094 over 5 years ago

Looks like we're on the legacy markup and they removed support for it today. We'll need to convert it to the <details><summary> markup you can find in the other drop downs. Most likely GHE will still need the current markup though.

posted by busches over 5 years ago

As a temporary solution, I created #2358 till we get a proper fix

posted by casz over 5 years ago

Seeing the same thing just now.

posted by coreysnyder over 5 years ago

@busches Nice catch! Created a fix PR.

posted by kidonng over 5 years ago

Just a confirmation ... the original report states this happens on Chrome. I'm on Firefox and seeing the same thing today. The menu is stuck open whether on old or new tabs and cannot be closed.

posted by alerque over 5 years ago

Same on Brave

posted by cocoonkid over 5 years ago

Same issue here

posted by MRamonLeon over 5 years ago

Hey guys please stop with the "me too" comments unless you have something to add. I think the point is made, this is broken, we have screen shots, we have browsers it's confirmed in, it's pretty universal.

Vote up the initial report if you want to add weight to the issue, and subscribe if you want to get updates, but (as with almost any project's Github issues) adding new comments just to say the same thing wastes a lot of people's time and attention. In case you missed it in comments there is a mitigation you can use for now and a permanent fix in the works.

posted by alerque over 5 years ago

@busches can you pin the issue? Before a new release we need to keep people informed. If not then we should keep this issue open

posted by kidonng over 5 years ago

@busches can you pin the issue? Before a new release we need to keep people informed. If not then we should keep this issue open

Good idea, done.

posted by busches over 5 years ago

@busches Let's also add the following line at the top of the issue description:

NOTE: A new version (19.8.21) has already been released, please restart your browser and wait for the plugin to update. For Chrome users, you can go to chrome://extensions/, toggle on "developer mode" on the top right corner, and click the "Update" button to immediately receive the update.

posted by kidonng over 5 years ago

Firefox users can hit 'Check for Updates' in Manage Extensions too (at least, it worked for me): image

posted by StormPooper over 5 years ago

Chrome users: v19.8.21 includes the fix, you can force update by using developer mode and clicking on update.

<img width="684" alt="Screen Shot 2019-08-21 at 12 49 07 PM" src="https://user-images.githubusercontent.com/1024246/63451397-19093500-c412-11e9-8625-472529da31eb.png">

posted by wachunei over 5 years ago

Thanks for quick fix ๐Ÿ‘Œ

posted by corysimmons over 5 years ago

https://github.com/sindresorhus/refined-github/issues/2357#issuecomment-523254108:

โ€ฆ scroll down and you will find more-dropdown โ€ฆ

:+1: โ€“ thanks โ€“ and for Waterfox Classic users of version 19.1.31.1822, which requires a manual entry:

image

posted by grahamperrin over 5 years ago

Can confirm brave and chrome fixed. thanks a bunch!

posted by cocoonkid over 5 years ago

For users on classic Waterfox, where the menu doesn't open anymore, here's an easy fix per UserStyle:

@namespace url(http://www.w3.org/1999/xhtml);

@-moz-document domain("github.com") {
  .btn-link.reponav-item:hover + .dropdown-menu-content.js-menu-content, .dropdown-menu-content.js-menu-content:hover { display:block !important }
  .dropdown-menu-content.js-menu-content { display:none; }
}

@busches maybe that could be integrated with refined-github?

posted by IzzySoft over 5 years ago

@IzzySoft, that seems like a bandaid solution. We're mimicking the native GH dropdowns and shouldn't need extra classes, assuming the native ones work without that fix. If the native ones do work and ours don't, that's the fix I'd want, which should be markup, not extra styling.

posted by busches over 5 years ago

Understood. Just thought to share what worked for me (might still be useful to other affected users then).

I still need this CSS fix, otherwise I cannot open that menu (where before it always remained open, it now always remains closed). For reference: I'm using the latest Waterfox Classic (56.2.14) on Linux Mint.

posted by IzzySoft over 5 years ago

Besides: where can one get it for Waterfox Classic now when installing fresh? AMO only has versions for FF61+, WF Classic would be FF57.

posted by IzzySoft over 5 years ago

โ€ฆ where can one get it for Waterfox Classic โ€ฆ

https://redd.it/aw8rqm

posted by grahamperrin over 5 years ago

Thanks! Maybe adding that link to the Readme here (in the "Install" section), to make it easier to find?

posted by IzzySoft over 5 years ago

I would hesitate. From the Reddit post, with added emphasis:

Version 19.1.31.1822 appears to be the last version that will show Jump to bottom in GitHub issues with Waterfox 56.2.7.1. Direct link:

Any number of other features may be incompatible โ€“ all recent versions for desktop are for Firefox 61.0 and later โ€“ I just noticed the disappearance (of Jump to bottom) when I updated too far.

posted by grahamperrin over 5 years ago

I'm running 18.12.22.1803 here, which still works โ€“ but receive no updates anymore. Afraid that version is no longer available at AMO, though. Maybe providing it (or any other APK you think should be used with Waterfox) at a separate URL โ€“ e.g. attach it to its tag/release here at Github โ€“ and link there?

posted by IzzySoft over 5 years ago

This is happening again and I am not sure what to do as I cannot disable more options...

This is in Chrome

posted by maniator about 5 years ago

Fund this Issue

$0.00
Funded

Pull requests