sindresorhus/refined-github

Potentially destructive actions should be opt-in and easily identifiable in settings #2318

ChadLevy posted onGitHub

I found that branches were automatically being deleted after pull requests. This causes conflicts with my project's workflow and is nothing something I wish to do.

Github has the option to automatically delete branches after pull requests are closed. I double checked to make sure this option was not enabled. It was not. Then, I looked in Refined Github's settings for this option and found it, automatically enabled, 2/3 of the way down a large list of other options:

image

I believe potentially destructive actions should be opt-in and easily identifiable in settings. While restoring a branch is trivial, there is still a potential for data loss and as such, whether or not this is done should be left up to the user.


there is still a potential for data loss

What is the potential data loss? You can restore any deleted branch.

posted by sindresorhus over 5 years ago

I was under the impression there was a time limit to restoring deleted branches and beyond that limit Github support would need to be involved. It looks like there is no time limit, so you're right, there is no potential for data loss given you can restore at any time.

posted by ChadLevy over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests