sindresorhus/refined-github

`deprioritize-marketplace-link` broken on Enterprise #2308

MartonEstok posted onGitHub

URL: Company hosted GitHub enterprise

Looks like Line 10 in refined-github/source/features/deprioritize-marketplace-link.tsx is accessing undefined returned by the selector '.Header-link[href="/marketplace"]'.

Probably because Enterprise edition doesn't have a marketplace link.

document.querySelector('.Header-link[href="/marketplace"]') also returns null when ran manually.

This is GitHub Enterprise Server 2.16.12.

Issue occurs even if I disable the rule in the extension settings.

image


This just need a exclude:[isEnterprise()] in deprioritize-marketplace-link

Issue occurs even if I disable the rule in the extension settings.

That's #2304

posted by fregante over 5 years ago
posted by fregante over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests