IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/refined-github

Console Errors #2290

yakov116 posted onGitHub

<!-- Thanks for reporting a bug! ā›° 1. Make sure the bug is caused by Refined GitHub. Try disabling the extension first. 2. Include a full URL where the bug appears. 3. Include a screenshot/gif Issues without a URL/screenshot will be closed --> 

āŒ edit-readme
content.js:2154 TypeError: Cannot read property 'dataset' of null
    at edit_readme_init (content.js:6917)
    at features_run (content.js:2149)
    at content.js:2195
    at content.js:2110
    at onAjaxedPagesRaw (content.js:2105)

On any page

content.js:2082 Uncaught (in promise) TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at onNewsfeedLoad (content.js:2082)
  • edit-readme was fixed by #2278
  • can't reproduce the second one. That code only runs on isDashboard
posted by fregante over 5 years ago

never mind looks like it was an error on my end

posted by yakov116 over 5 years ago
  • can't reproduce the second one. That code only runs on isDashboard

Can reproduce on issues and PRs on forced reload. That's not related to user dashboard, this issue looks like it's from show-names. Specifically onNewFeedLoad function used as load function for one of show-names's declaration in #2229.

image

This function should not be called on issues/PRs, but somehow it is and fails on https://github.com/sindresorhus/refined-github/blob/bc7d35cda229ea5e282f8cb6f5a62b9e09c1f5a0/source/libs/on-newsfeed-load.ts#L11. Causing elementReady on https://github.com/sindresorhus/refined-github/blob/bc7d35cda229ea5e282f8cb6f5a62b9e09c1f5a0/source/libs/on-newsfeed-load.ts#L17 to go into a rAF callback forever. Was experiencing something similar when profiling #2087 (the little callbacks in this screenshot on the either side).

image

I suspect this might be the same issue as #2273.

posted by notlmn over 5 years ago

@fregante same as above

posted by yakov116 over 5 years ago

Try #2292

@notlmn those rAFs aren't ours; elementReady stops on dom ready.

posted by fregante over 5 years ago

@notlmn those rAFs aren't ours; elementReady stops on dom ready.

Sorry, found that those are from hide-files-on-github: https://github.com/sindresorhus/hide-files-on-github/pull/82.

posted by notlmn over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

Ā© 2019 BoostIO, Inc.