sindresorhus/refined-github

Should Subscribe reason be hidden in Sidebar? #2269

trivikr posted onGitHub

Issue

The feature clean-sidebar hides the subscribe reason in the code below: https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

Screenshots

  • UX (without refined-github on left, and with refined-github on right) Before)After

  • DevTools DevTools

Expected behavior

  • Power GitHub users who use refined-github extension are subscribed to multiple issues and might want to know the reason why they're subscribed to particular issue in order to decide if they want to Unsubscribe. The reason shown below Unsubcribe button is helpful.
  • clean-sidebar feature description states Hide all empty sections (or just their "empty" label) in the discussion sidebar. As per description, it shouldn't hide non-empty reason for subscription.

What do you feel about showing reason in sidebar?

As of now, I'm overriding this behavior by writing following custom CSS in my extension:

.sidebar-notifications .reason {
    display: inline-block !important;
}
posted by trivikr over 5 years ago

Any update on this request?

Can we at least move the following CSS to a new feature (say hide-subscription-reason) so that it doesn't break existing users? https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

The users who like to see the subscription reason will just be able to disable that feature, without affecting other clean-sidebar features

posted by trivikr over 5 years ago

Any update on this request?

I'll post a PR over the weekend to move the below CSS to new feature hide-subscription-reason: https://github.com/sindresorhus/refined-github/blob/4bc3f3aa213de18d89c32df454957752400f249f/source/features/clean-sidebar.css#L6-L9

posted by trivikr over 5 years ago

This is not big enough to justify a whole feature for it. Either it goes or it stays and you keep the CSS in the Custom CSS field.

cc @sindresorhus

posted by fregante over 5 years ago

The copy looks a bit messy there with the Mark as unread button but perhaps it can be moved above Subscribe via flexbox

posted by fregante over 5 years ago

This is how "Mark as unread" button will look like if moved above Subscribe Screen Shot 2019-08-05 at 7 18 47 AM

posted by trivikr over 5 years ago

I meant the copy can be moved above the subscribe button:

subscribe reason [unsubscribe button] [mark as unread button]

posted by fregante over 5 years ago

Screenshot as per suggestion from @fregante Screen Shot 2019-08-05 at 11 14 12 PM

posted by trivikr over 5 years ago

Sure, we can bring back the subscribe reason.

posted by sindresorhus over 5 years ago

Sure, we can bring back the subscribe reason.

Cool! Where should the subscribe reason be placed?

  1. Original location (below Subscribe/Unsubscribe button) 61831574-0dcae580-ae23-11e9-96bd-0fe3dd060800

  2. Original location, with "Mark as Unread" button moved to top 62471344-636f8e00-b751-11e9-998d-7e1415c77e93

  3. New location, above Subcribe/Unsubscribe button 62515316-d838db80-b7d6-11e9-8e02-17b6188ba8ca

My vote goes for 2, as it's minimal changes from the default behavior from UX perspective

posted by trivikr over 5 years ago

I think 3 is best. We shouldn't flip the two buttons like in 2, especially because Mark as unread is added later so it will replace Unsubscribe (causing possible mis-clicks)

posted by fregante over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests