The issue has been closed

Add option to only render boundary whitespace #2266

leggsimon posted onGitHub

I really like the new rendering of whitespace in PRs (I always have it enabled in my text editor) however personally I think it’d be nice to be able to choose to only render “boundary” whitespace instead of all of it.

VSCode’s definition of “boundary” whitespace is “Whitespace characters except for single spaces between words”.

Small example (ignore the squiggly): <img width="189" alt="Screen Shot 2019-07-23 at 13 37 09" src="https://user-images.githubusercontent.com/11544418/61712778-ff12fe80-ad4e-11e9-9f9e-703c131419ba.png" alt="Code screenshot showing `, async () => { `">

Here it’s not rendering the space character between the comma and the async keyword, but then there’s two spaces between async and the opening bracket so they get rendered and then finally any trailing whitespace gets rendered.

I can’t recall whether any features allow for different options rather than just on/off which might be a blocker to this potentially. My thought being that the options become Off, Boundary, & All

This is not possible without parsing the file itself, in each language. It's out of RGH's scope

posted by bfred-it over 5 years ago

Ahh yeah I guess, I wonder if you could do a rudimentary (pseudocode)

if two_spaces_together
    render_spaces_as •
else if spaces_at_end_of_line
    render_spaces_as •
else
    dont_render

I wonder if this might cover most cases (although I don’t really know the semantics of most other languages)

posted by leggsimon over 5 years ago

I never have “two spaces together” in my code, your example wouldn’t pass xo lint. “Two spaces together” don’t mean what you mean

posted by bfred-it over 5 years ago

Yeah, that’s fair. I’ll close this in that case

posted by leggsimon over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Add option to only render boundary whitespace #2266

Company

Community

Support

Connect