The issue has been closed

`edit-files-faster` and `edit-readme` should not be added to commits and tags #2261

fregante posted onGitHub

Files are only editable when you're on a branch, not on a specific commit or tag. Clicking the "Edit file" button will lead you to a 404 page

Test urls

edit-readme

https://github.com/chartjs/Chart.js/tree/v2.8.0

This is my view after clicking the button:

posted by jerone over 5 years ago

Yes, now click the "Fork this repository" button, it's a 404.

I guess links are straight 404s only on your own repos (or if you already have the fork)

posted by bfred-it over 5 years ago

Hmmm, I could swear this worked before. 🤔

But it makes sense. It's only possible to commit to branches, not to tags.

posted by jerone over 5 years ago

GitHub adds “edit readme” links on commits as well but they will point to master, like /edit/master/readme.md so we should do the same

posted by bfred-it over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests