The issue has been closed

Duplicated “Update Branch” button #2213

marcobiedermann posted onGitHub

Description

When “Require branches to be up to date before merging” is enabled in branch protection and branch in PR is not up to date, I see two buttons to update it

Environment

https://github.com/<USERNAME>/<REPO>/pull

Screenshot

I'm seeing the same problem. Not sure yet what's going on, but the related piece of code is here:

https://github.com/sindresorhus/refined-github/blob/90226744b60546d48006db95cf1352d1e7a7d580/source/features/update-pr-from-base-branch.tsx#L59-L86

Maybe GitHub changed the way they impementated their update branch button. It is possible to avoid adding the button if the GitHub version was already found:

if (select('.branch-action-btn')) {
  return;
}

posted by bobvanderlinden over 5 years ago

Yep, that'd be great. Line 60 should probably be:

 if (select.exists('.rgh-update-pr-from-master, .branch-action-btn')) {

But I think .branch-action-btn includes other similar buttons nearby, so it needs to be more specific.

posted by bfred-it over 5 years ago

Fund this Issue

$0.00

Funded

Pull requests

Duplicated “Update Branch” button #2213

Description

Environment

Screenshot

Company

Community

Support

Connect