Do you want to work on this issue?
You can request for a bounty in order to promote it!
Various fixes for `global-discussion-list-filters` feature #1926
mcornella posted onGitHub
Fixes https://github.com/sindresorhus/refined-github/issues/1919
Links to reproduce: global Pull Requests or Issues, then click either the Commented
or Yours
button.
Things this PR fixes:
In the global Issues page, the proper parameter is put in the URL so the filter is correct (i.e. pull requests don't appear as well).
When in a
Commented
orYours
query, the added query parameter is removed correctly from the rest of the buttons URLs (Created
,Assigned
,Mentioned
andReview requests
). The previous behaviors removed one space too many leading to parameters joined together. Fixes #1919.When the query parameters contained a malformed query, the
Commented
orYours
buttons don't light up. For example, if the query containscommented:username-and-something-else
, the regex doesn't match now, as opposed to it matching previously and highlighting theCommented
button.In the global Pull Requests page, the
Commented
andYours
buttons also include in the query the parameteris:pr
, as was done foris:issue
(fix 1) in the Issues page.
These fixes are listed in the order of the commits.
cc @bfred-it