The issue has been closed

Auto-retry for PR merges #1716

DanielRosenwasser posted onGitHub

I work on TypeScript, and periodically do DefinitelyTyped duty, merging in type declarations for various untyped packages on npm. This extension has helped me a ton.

Much of the time, PRs are pretty easy to merge in and I can do many at a time; however, sometimes GitHub can't keep up!

I'll have to wait around to hit the "try again" button and try to merge.

This ends up making the process take a lot longer, and when there are so many @sindresorhus packages for the world to type :wink:, this can really start to add up.

Much like this extension adds a "merge when tests pass" feature, it'd be useful to us if there was also an auto-retry-on-failed-merge feature.

I get that this sounds like a pretty unique case, but it very well could be useful for other similar repositories. If it's too out there, I'd understand. :slightly_smiling_face:

This code is likely to be 90% similar to https://github.com/sindresorhus/refined-github/blob/master/source/features/pr-branch-auto-delete.tsx

The core is: when the user clicks the merge button, wait the button to show up, then press it. In both cases the MutationObserver should be disconnected when there's no button at all.

posted by fregante over 5 years ago

A fair warning here: "Try again" button does NOT use the merge method you chose but instead always chooses regular merge. Auto-clicking it may result in unwanted merge commit when you're using squash for example. It's a GitHub issue but with that in mind I try my best to never accidentally click that button.

posted by jack1142 almost 5 years ago

A fair warning here: "Try again" button does NOT use the merge method you chose but instead always chooses regular merge. Auto-clicking it may result in unwanted merge commit when you're using squash for example. It's a GitHub issue but with that in mind I try my best to never accidentally click that button.

If this is true I think we should not do this

posted by yakov116 about 4 years ago

Being a bug it's possible that GitHub has fixed it in the meanwhile. Worth a double-check. Thanks for pointing that out

posted by fregante about 4 years ago

GitHub showed me this message because I tried merging while a new commit was just pushed, the error message included this piece of information too.

I think it's a fair warning that the merger should know about, so I don't think it's safe to retry automatically.

posted by fregante almost 4 years ago

Fund this Issue

$0.00

Funded

Pull requests

Auto-retry for PR merges #1716

Company

Community

Support

Connect