The issue has been closed

Keyboard shortcut for submitting the review changes on a PR #1069

vanniktech posted onGitHub

Given I'm on a PR and review the files I'd like to hit a keyboard shortcut to let me review the changes. Possibly, r could be used.

Then for accepting, rejecting, or commenting we could use a, r and c.

Shortcuts for immediately accepting / rejecting / commenting from the PR file page itself would also be nice. Maybe something like

r + a => accept
r + r => reject
r + c => comment

Unlocking this to discuss an alternative shortcut since g r is used by releases-tab

posted by fregante almost 5 years ago

I also don't like <kbd>v</kbd> as a shortcut for "Review" particularly much, but other options were already taken:

<kbd>g</kbd> <kbd>5</kbd> would fit well alongside these (from RGH's pull-request-hotkey), but would wrongly imply that review was a separate tab:

Screenshot_2020-05-30_13-22-37

So I settled with <kbd>v</kbd> for "review".

posted by FloEdelmann almost 5 years ago

Fund this Issue

$0.00

Funded

Pull requests