Fix cannot open url contains `|` on windows #98

baoti posted onGitHub

Alright, let's try out this then:

If contains space, DO NOT escape;
otherwise, DO escape.

posted by sindresorhus almost 6 years ago

@baoti Can you fix the merge conflict?

posted by sindresorhus almost 6 years ago

@sindresorhus I got the reason for doing not escape which contains space char. The argument would be wrapped in double quotes. See source for detail.

We can pass childProcessOptions.windowsVerbatimArguments = true to disable it, and always escape target by double quotes.

posted by baoti almost 6 years ago

Good find. Let’s do that then.

posted by sindresorhus almost 6 years ago

Fund this Issue

$0.00

Funded

Only logged in users can fund an issue

Pull requests