sindresorhus/opn

Do you want to work on this issue?

You can request for a bounty in order to promote it!

URL with $ does not work on WSL 2 #202

CryogenicPlanet posted onGitHub

Bug: The opened URL is randomly missing ${word}

Found bug when using amplify-cli https://github.com/aws-amplify/amplify-cli/issues/5664

Enviorment:

  • WSL 2
  • "open" : "^7.3.0",

Code snippet:

const open = require("open");

const deepLinkURL = "https://localhost/users$new?step=abc"

open(deepLinkURL, { wait: false }).catch(() => { });

image

Related to #170 and #171


// @Pytal @tim-stasse

posted by sindresorhus over 4 years ago

Looking at #170 I think I found a solution

I think a change here from this to https://github.com/sindresorhus/open/blob/f3748e4f5a04a41e27034aff1eb08e8b86d01c1c/index.js#L104-L106

 } else { 
     encodedArguments.push(`'${target}'`); 
 } 

will solve the escaping problems on WSL, I can create a PR for the same.

posted by CryogenicPlanet over 4 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests