IssueHunt
Bug Bounty (New!)
Browse
Sign in with GitHub
sindresorhus/DockProgress

How to complete DockProgress in 4.3.0 version #20

Kyle-Ye posted onGitHub

In the 3.2.0 version, if we set the progress value to "1.0". The extra dock progress will be hidden.

https://github.com/sindresorhus/DockProgress/blob/7100b68571e2dafe3a06ad5905b80fc3b0107b4b/Sources/DockProgress/DockProgress.swift#L79

The above logic does not seem to have been retained in the latest version 4.3.0.

Related Issue: https://github.com/XcodesOrg/XcodesApp/issues/529#issuecomment-2017401127

Would you be able to try out this commit? https://github.com/sindresorhus/DockProgress/commit/d4f23b5a8f5ca0fac393eb7ba78c2fe3e32e52da

posted by sindresorhus about 1 year ago

Would you be able to try out this commit? d4f23b5

Tried it. It works.

Would you minding releasing a new version (eg. 4.3.1 or 4.4.0) for it? Thanks

See https://github.com/XcodesOrg/XcodesApp/pull/545

posted by Kyle-Ye about 1 year ago

https://github.com/sindresorhus/DockProgress/releases/tag/4.3.1

posted by sindresorhus about 1 year ago

Fund this Issue

$0.00
Funded

Pull requests

Company
AboutMission
Community
SpectrumEmbed
Support
FAQTerms of usePrivacy policyCode of conductCredits
Connect
FacebookTwitter

© 2019 BoostIO, Inc.