saberland/saber

Do you want to work on this issue?

You can request for a bounty in order to promote it!

Add --no-inline build flag (for CSP compatibility) #593

andreasvirkus posted onGitHub

<!-- Please don't delete this template or we'll close your issue -->

<!-- Before creating an issue please make sure you are using the latest version of Saber. -->

Feature request

<!-- Please ask questions via following several ways. -->

<!-- https://chat.saber.land/ -->

<!-- https://stackoverflow.com/questions/ask?tags=saberjs -->

What problem does this feature solve?

It would allow users to keep very strict CSP directives (since the output is often a simple static site) by removing inlined styles and base64-inlined images.

What does the proposed API look like?

Maybe a --no-inline flag passed in to saber build?

How should this be implemented in your opinion?

When the flag is present, CSS should be written to their own files instead of being inlined in the document's <head>, same for images (maybe this can already be avoided by using saber-image, I've yet to test that?).

Are you willing to work on this yourself?

Yes, with some guidance 🙏


Sorry if this is already somehow solvable by existing features.


You can manually modify webpack config but it's kinda verbose, we can add new build option (https://saber.land/docs/saber-config.html#build) to control this. Similar to this option (https://poi.js.org/config.html#assets-inlineimagemaxsize) in Poi.

CSS can already be extracted https://saber.land/docs/saber-config.html#extractcss

posted by egoist almost 5 years ago

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests