saberland/saber

Do you want to work on this issue?

You can request for a bounty in order to promote it!

sass-loader v8+ compatibility #587

Liwoj posted onGitHub

<!-- Please don't delete this template or we'll close your issue -->

<!-- Before creating an issue please make sure you are using the latest version of Saber. -->

<!-- Issues which contain questions or support requests will be closed. -->

<!-- Please ask questions via following several ways. -->

<!-- https://chat.saber.land/ -->

<!-- https://stackoverflow.com/questions/ask?tags=saberjs -->

Bug report

Including sass files while using sass-loader version 8+ throws error when compiling the app

ValidationError: Invalid options object. Sass Loader has been initialised using an options object that does not match the API schema. - options has an unknown property 'indentedSyntax'. These properties are valid: object { implementation?, sassOptions?, prependData?, sourceMap?, webpackImporter? } at validate

Reason is sass-loader introduced breaking change in 8.0 moving all sass options under sassOptions sub-key

Problematic file is config-css.js

Fix will be probably hard without introducing incompatibility with previous versions of sass-loader. Are you sure this option is actually necessary ? My understanding is both node-sass and dart-sass are able to switch between syntax based on file extension - indented for sass and non-indented for scss

Other problem I see is that in saber-config the build.loaderOptions.sass is used for both sass and scss configuration. It would be useful to have dedicated key just for scss

Steps to reproduce

<!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- You can also use this CodeSandbox starter https://bit.ly/2IlcpNF -->

What is expected?

What is actually happening?

Other relevant information

  • Result of running saber -v:
  • Browser version (optional):
  • Is Saber a global or local install?
  • Which package manager did you use for the install?
  • Does this issue occur when all plugins are disabled?

Fund this Issue

$0.00
Funded
Only logged in users can fund an issue

Pull requests