saberland/saber

Setting default document title and meta description #555

egoist posted onGitHub

<!-- Please don't delete this template or we'll close your issue -->

<!-- Before creating an issue please make sure you are using the latest version of Saber. -->

Feature request

<!-- Please ask questions via following several ways. -->

<!-- https://chat.saber.land/ -->

<!-- https://stackoverflow.com/questions/ask?tags=saberjs -->

What problem does this feature solve?

Adding default <title> and <meta name="description"> based on siteConfig.title and siteConfig.description in your Saber config file.

How should this be implemented in your opinion?

Adding them to root Vue instance: https://github.com/saberland/saber/blob/a485cf80b8267ece7f25e59706a260e26130105a/packages/saber/vue-app/create-app.js#L43


That's a good idea. We probably do that on every application! Nothings here! Whistling

posted by the94air over 5 years ago

@egoist Hi, I wanna try to contribute code for this feature : )

posted by M1seRy over 5 years ago

@M1seRy 👬 Let's do it

posted by egoist over 5 years ago

@egoist check #pr556

It is always nice to try new things, it's my first time to use Saber ( writing my blog with Hexo before), I really looking forward to doing more things for this project ❤️

posted by M1seRy over 5 years ago

Fund this Issue

$0.00
Funded

Pull requests