remotion-dev/remotion

Proposal: Allow to omit `durationInFrames={Infinity}` for sequence #526

JonnyBurger posted onGitHub

We can make it that if you omit it this is assumed as default. Makes the syntax a bit more concise.


Or -1 😎

posted by nandorojo over 3 years ago

We could allow it as well, but isn't it better if you can just not specify anything at all? 😁

posted by JonnyBurger over 3 years ago

Yeah agreed

posted by nandorojo over 3 years ago

🎃 This issue is eligible for Hacktoberfest! In addition to helping you get a contribution towards your Hacktoberfest reward, Remotion pays a $100 bounty for it!

Read: How to contribute to Remotion

  • Let us know when you are interested in this issue, and we'll assign you!
  • In order to prevent issues from getting stuck, try to progress the issue by opening a PR and adding commits. If your progress is stale for 7 days, another user can ask to take over the issue.

Approval criteria for this PR:

  • Make the durationInFrames property optional for the <Sequence /> component and fallback to Infinity.
  • Update the documentation for <Sequence />.
  • Update the examples in the documentation
  • Go through the list of templates and make a PR to remove the durationInFrames={Infinity} props if necessary
  • Extend the ESLint plugin to give a warning if durationInFrames={Infinity} is set. You can duplicate this rule which is very similar and adjust it.
posted by JonnyBurger over 3 years ago

@jonnyburger has funded $112.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

@JonnyBurger Just gone through the Sequence compoent and some tests, I can take this.

posted by khalid283 over 3 years ago

@khalid283 You got it! Good luck 🎃

posted by JonnyBurger over 3 years ago

@jonnyburger has rewarded $100.80 to @khalid283. See it on IssueHunt

  • :moneybag: Total deposit: $112.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $11.20
posted by issuehunt-app[bot] over 3 years ago

Fund this Issue

$112.00
Rewarded

Rewarded pull request

Recent activities

khalid283 was rewarded by jonnyburger for JonnyBurger/remotion# 526
over 3 years ago
jonnyburger submitted an output to  JonnyBurger/ remotion# 526
over 3 years ago