remotion-dev/remotion

Add twoslash to docs #447

JonnyBurger posted onGitHub


While working on this, I've found out that there are certain things that need to be fixed before we add twoslash to the documentation. For example, implicit React imports in tsx and jsx code blocks, jsx blocks not being highlighted properly, etc. I've already opened a bunch of issues on the twoslash repo. Before then, this feature is probably blocked.

I've also submitted a PR (#465) that does nothing but add a tsconfig.json so that docusaurus theme imports don't bother as errors in your IDE of choice.

posted by frencojobs over 3 years ago

Oh ok, thanks a lot for investigating it! That means JSX is not well supported yet then?

No problem, let's integrate it when it's stable. In the meanwhile, your other PR was merged 🤝

posted by JonnyBurger over 3 years ago

@jonnyburger has funded $100.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

Hi @JonnyBurger, let me work on this. I've been keeping myself a tad active on the twoslash repo and have pointed bugs to and fixed, to work best with current docs.

posted by frencojobs over 3 years ago

@frencojobs I am assigning you this issue. All the best :fire:

posted by Iamshankhadeep over 3 years ago

@jonnyburger has funded $12.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

@jonnyburger has funded $50.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

@jonnyburger has rewarded $145.80 to @frencojobs. See it on IssueHunt

  • :moneybag: Total deposit: $162.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $16.20
posted by issuehunt-app[bot] over 3 years ago

Fund this Issue

$162.00
Rewarded

Rewarded pull request

Recent activities

frencojobs was rewarded by jonnyburger for JonnyBurger/remotion# 447
over 3 years ago
jonnyburger submitted an output to  JonnyBurger/ remotion# 447
over 3 years ago