remotion-dev/remotion

Allow <source> elements to be placed inside a <Video> or <Audio> element #364

JonnyBurger posted onGitHub

We should rely mostly on browser mechanisms, but it will require some tweaks from our side on the video and audio components to achieve this.


@jonnyburger has funded $60.00 to this issue.


posted by issuehunt-app[bot] almost 4 years ago

Hello @JonnyBurger ,

I am interested to work on this one. So to be clear, we want to be able to do something like below?

<Video 
  startFrom={59}
  endAt={120}
  style={{height: 1080 / 2, width: 1920 / 2}}
>
  <source src="movie.mp4" type="video/mp4">
  <source src="movie.ogg" type="video/ogg">
</Video>
posted by mikaoelitiana almost 4 years ago

@mikaoelitiana

Hi Mika,

thanks a lot for wanting to work on it! Yes you are correct, this is exactly the idea. You probably need to allow the video component to pass some children, and allow to not pass the src prop directly. I think there is a registerVideo call somewhere which also requires the source, so maybe you need to figure out programmatically for which src the browser has decided.

If you struggle along the way, still feel free to open a draft PR and we can help you!

posted by JonnyBurger over 3 years ago

Hi everyone! 👋🏽 @mikaoelitiana, I was wondering if you're still interested in this issue or if I can work on it. Cheers!

posted by arthurdenner over 3 years ago

hello @arthurdenner yes I am still working on this one, hope to complete it by next week

posted by mikaoelitiana over 3 years ago

@jonnyburger has rewarded $54.00 to @arthurdenner. See it on IssueHunt

  • :moneybag: Total deposit: $60.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $6.00
posted by issuehunt-app[bot] over 3 years ago

We reverted it and decided that we will not pursue it in the foreseeable future. Too complicated and there are browser bugs out there as well

posted by JonnyBurger over 3 years ago

Fund this Issue

$60.00
Rewarded

Rewarded pull request

Recent activities

arthurdenner was rewarded by jonnyburger for JonnyBurger/remotion# 364
over 3 years ago
jonnyburger submitted an output to  JonnyBurger/ remotion# 364
over 3 years ago