remotion-dev/remotion

Keyboard controls for player #342

JonnyBurger posted onGitHub


@JonnyBurger I would like to pick this up If you can provide me some context about what all things have to be done

posted by ashikmeerankutty over 3 years ago

Thanks again for the previous PR! This one is mainly being able to hit the space button to pause and play the video.

The main challenge is probably what happens if multiple players are on the page, there needs to be some kind of focus management.

Also there should be a prop to disable it if you want to use the player on the website and handle the space bar separately.

Thinking of it, there are no important keyboard shortcuts other than the space bar that I can think of.

posted by JonnyBurger over 3 years ago

The focus part seems to be a bit tricky rest is fine. I will try to figure out what kind of focus management is used in such cases and let you know what can be done.

posted by ashikmeerankutty over 3 years ago

We also welcome an initial draft PR without the focus management. Any help is appreciated 🙌

posted by JonnyBurger over 3 years ago

@jonnyburger has funded $40.00 to this issue.


posted by issuehunt-app[bot] over 3 years ago

Sure, I will start with the keyboard controls then and once everything works fine we can try the focus management.

posted by ashikmeerankutty over 3 years ago

@jonnyburger has rewarded $36.00 to @ashikmeerankutty. See it on IssueHunt

  • :moneybag: Total deposit: $40.00
  • :tada: Repository reward(0%): $0.00
  • :wrench: Service fee(10%): $4.00
posted by issuehunt-app[bot] over 3 years ago