The issue has been solved

`<Loop>` component #254

JonnyBurger posted onGitHub

A core component that will loop any of it's children indefinitely.

It should accept two props:

durationInFrames: The duration of the content to be looped
times: How many times to loop (optional, default Infinity)

It should only loop at most as many times to fill the whole composition length, but not any longer (can just call useVideoConfig() inside the loop component to figure out the max number of loops). Here is an example of how we loop at the moment: https://github.com/remotion-dev/remotion/discussions/615.

The component should throw descriptive errors on missing props or props with bad types, and documentation should be added to packages/docs

🎃 This issue is eligible for Hacktoberfest! In addition to helping you get a contribution towards your Hacktoberfest reward, Remotion pays a $100 bounty for it!

Read: How to contribute to Remotion

Let us know when you are interested in this issue, and we'll assign you!
In order to prevent issues from getting stuck, try to progress the issue by opening a PR and adding commits. If your progress is stale for 7 days, another user can ask to take over the issue.

Approval criteria for this issue

Implement the component as described above
Keep the pipeline green
Add documentation with a similar level of quality as the current docs

@jonnyburger has funded $75.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

posted by issuehunt-app[bot] almost 4 years ago

I can help with ffmpeg filters if needed 😉 But I don't have much knowledge of the remotion code base

posted by Maxou44 almost 4 years ago

@Maxou44 If you know how to implement loops with trimming support (start and end marker) and can give an example, it will help the implementation move forward faster for sure 😊

posted by JonnyBurger almost 4 years ago

as mentioned in #381 it would actually be cooler to have a <Loop> high order component so you can loop anything, not just audio and video! It's probably easier to implement and more versatile. So I am now leaning more towards this.

posted by JonnyBurger almost 4 years ago

Hey @JonnyBurger ! Can I take up this issue?

posted by sohamsshah over 3 years ago

@sohamsshah Sure thing! Good luck 🎃

posted by JonnyBurger over 3 years ago

@JonnyBurger I would like to take this issue if there is no one working on it

posted by bpedersen over 3 years ago

Sure go ahead 👍. Apologies for the delay; @JonnyBurger I will take up another issue later :)

posted by sohamsshah over 3 years ago

Just saw the reference to the Freeze approach. I will work on changing to that approach tonight.

posted by bpedersen over 3 years ago

Updated to change the frame in the TimelineContext. Manually tested that this works with other nested Loop and Freeze also freezes the correct frame based on the nested loops.

posted by bpedersen over 3 years ago

@jonnyburger has rewarded $67.50 to @bpedersen. See it on IssueHunt