Unify line breaks #3813

json1.dll saves custom properties in a different way which may not be compatible with newer parsers, and as such is not a suitable workaround in many cases.

+1 for consistency, either via only using \n or by providing an option within Tiled. I'm on Windows, but would be quite happy with \n.

I'm really surprised by the observed difference between the json and json1 plugins, given that they both open the target file in text mode and should hence observe system-dependent line endings.

Regardless, I'm afraid this behavior would need to be configurable since I'm not sure everybody would agree that CRLF is "ancient technology". Many people may rely on Git to help translate line endings on checkout / checkin, so would have their JSON files on Windows using \r\n but just \n on Linux and macOS, and if Tiled would save on Windows with \n it might cause issues for them (I haven't checked, of course).

I'm not sure when Windows Notepad learned to open LF files correctly, but for a long this time this editor could not and I think it was the main reason to keep saving text files with CRLF on Windows...

A line endings: [OS default / LF / CRLF] dropdown would be neat. I wouldn't be surprised if there were some games out there expecting specifically CRLF tripping up Mac users xP

On a related note, it'd be nice if this and the minify option were exposed to scripting, so that they could affect custom export formats as well.

Edit: Presumably this should also affect storage of string custom property values?

I'm not sure when Windows Notepad learned to open LF files correctly, but for a long this time this editor could not and I think it was the main reason to keep saving text files with CRLF on Windows...

I believe that happened in 2018: https://devblogs.microsoft.com/commandline/extended-eol-in-notepad/

Making line endings configurable is a fair compromise, even if there isn’t a good reason to continue saving with CRLF on Windows by default.

As a contrast, I don’t see anyone arguing to add “CR” line endings as an option for Classic Mac OS! Those are even more obsolete than CRLF; a transition which started with the introduction of Mac OS X in 2001.

As a contrast, I don’t see anyone arguing to add “CR” line endings as an option for Classic Mac OS!

Well, obviously, because nobody is running Mac OS 9 anymore... but if you would somehow be able to port Tiled to it, it would use "CR" for text files written there. :-)

But yeah, at least Notepad has supported LF for about 4 years now, and personally I also think we could use it by default as part of adding the option to use native line-endings.

but if you would somehow be able to port Tiled to it, it would use "CR" for text files written there. :-)

In theory, yes! Although json1.dll should write files with CRLF on Windows if that was true in general.

CRLF is still the default for Windows (Notepad in Windows 10, not sure about 11, I expect it is the same).

Is this issue specifically about JSON output? I was working on a feature request for an option in the editor to select EOL in the settings for exported/saved maps.

I started working on adding the feature to potentially create a PR. But if this is already in the works then I will discontinue it.