Fit map in view does not work when tile size is 1 #3524

Looking at the code, this behaviour is intentional: https://github.com/mapeditor/tiled/blob/48c4f85616fe3bc4e0d723310aa6ae38a261bb55/src/tiled/mapview.cpp#L157-L165

However, I'd also rather see the map zoomed out, even if that means lag. The main use of Fit Map in View is to deal with large maps, I feel. A performance hit is an acceptable price, especially since users who find this feature not working as expected for large maps are likely to zoom out anyway.

Yep - I would agree that the performance hit is acceptable. Maybe this could be on a user preference setting? "Allow large fit in view"

I have implemented this on a local build and will generate a branch and pull-request when I have time.

I'm not even sure this needs to be a user preference, it seems like clutter to me. I think users working with large maps expect some performance hitches sometimes, and all this option does is make Fit Map in View not do what it says. I think users for who this performance optimization might make a positive difference would quickly learn not to use Fit Map in View at all :'D

Yep - I'm tempted to agree. Is the Fit Map in View ever called outside of user control? e.g. when opening a map for the first time?

Not that I can find. fitInView() and fitMapInView() are only called via the action. When creating or opening new maps, Tiled seems to use 100% zoom centred on 0,0.

Okay - Shall I amend my commit request to remove the user settings and make the feature work without restrictions?

I think it would be good to hear @bjorn's opinion, perhaps there's some reason for the performance mindfulness that we've both overlooked.

Is the Fit Map in View ever called outside of user control? e.g. when opening a map for the first time?

Yes, in this piece of code:

https://github.com/mapeditor/tiled/blob/7fa253f244d2d2d74796f0e1fd7ea2d70a5250f3/src/tiled/mapview.cpp#L461-L468

If needed, we can of course differentiate between the automatic version and the manual action, such that only the automatic case has a minimum zoom level.

I would personally also like to avoid adding an option for this.