Display ALL keyboard shortcuts #3368

Additionally, it would be nice if there was some indication that a shortcut has been modified or that it is the default. An icon would probably be best, since icons could be used even on those shortcuts that are unset, unlike differing text styles/colours.

Modified shortcuts have the entire row displayed in bold (and conflicts turn rows red):

That should suffice, right?

In my dark Tiled Fusion theme, the difference between bold and not bold is fairly minor and I have a hard time spotting it, especially if I've looked up the action by name and don't have a non-modified bit of text to compare with. I'd completely forgotten about the bolding, because it's not been useful for spotting defaults vs non-defaults ):

Red for conflicts is fine. However, I hope conflict spotting can be improved, as currently conflicts don't seem to be reported when they involve secondary shortcuts, as you can see in the screenshot above. Ctrl+W is the secondary shortcut for Close, but setting StampTool to use it does not report a conflict (though the conflict is reported to the external console if I run Tiled from console, QAction::event: Ambiguous shortcut overload: Ctrl+W). Instead, it just silently breaks my ability to either Close or activate the Stamp Brush with my keyboard, and Ctrl+W works as Close when I'm in a context where the the Stamp Brush is not available.

I hope conflict spotting can be improved, as currently conflicts don't seem to be reported when they involve secondary shortcuts, as you can see in the screenshot above. Ctrl+W is the secondary shortcut for Close, but setting StampTool to use it does not report a conflict

This part has been fixed in 5011f77cb01a25f2a7509d91e0f3ea8a96d2a8d3. It also adjusts the key: filter to look for all shortcuts on an action, even though alternative shortcuts are not displayed yet (changing that is beyond the scope of 1.8.x releases).