hassio-addons/addon-spotify-connect

Discovery Mode needs access to local network #39

grunjol posted onGitHub

Problem/Motivation

Recently discovery mode was added but it doesn't seem to work https://github.com/hassio-addons/addon-spotify-connect/issues/33#issuecomment-576923911

Expected behavior

If you leave username and password empty, a spotify connect instance should be discoverable on the local network instead of establish a connection with spotify api.

Actual behavior

The instance is not discoverable on the local network BUT appears on the bridged (private) hassio network (i can see the HA discovers the instance but its an unknown type, so it discards it)

Steps to reproduce

Run addon in discovery mode (empty user/pass)

Proposed changes

librespot uses mDNS to publish the listening port. mDNS uses IP multicast but is bounded to the internal private network, so it doesn't propagate to the users/clients .

A possible solution could be set host_network: true in the addon config


:wave: Thanks for opening your first issue here! If you're reporting a :bug: bug, please make sure you include steps to reproduce it. Also, logs, error messages and information about your hardware might be useful.

posted by addons-assistant[bot] almost 5 years ago

I cloned the repo and added "host_network": true in the config file and can confirm discovery is working fine in local network

posted by grunjol almost 5 years ago

@grunjol where exactly did you add that line? do you want to make it a pull request?

posted by daerSeebaer almost 5 years ago
posted by grunjol almost 5 years ago

Yes, but we are not there yet... Home Assistant gets a new audio layer, which we are currently testing with this add-on as well.

posted by frenck almost 5 years ago

v0.8.0 released.

posted by frenck almost 5 years ago

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

posted by addons-assistant[bot] almost 5 years ago

Fund this Issue

$0.00
Funded

Pull requests