ever-co/gauzy

Fix :: Selected tag option lists cannot be view [Employee] #5811

rahul-rocket posted onGitHub

Description 📜

Current Behavior:

Notice that the selected tags cannot be view or even scroll on the field.

Expected Result:

Selected tags should be able to view on the field.

URL: https://demo.gauzy.co/#/pages/accounting/income

Pre- Condition: User selected multiple tags on the list

Steps:

  1. Load the URL
  2. Log in as an employee
  3. Click Accounting tab
  4. Go to Income
  5. Select multiple tags on the option list
  6. Verify that the selected options are not able to view properly on the field

Illustration 🍂

https://drive.google.com/file/d/1XFsrhO3duy-eUdBYj1-L343wgYByyQ7V/view


@rahul-rocket @evereq Showing the selected dropdown item in that small field is tedious (i.e. adding a vertical scroll)

posted by Gramosx over 1 year ago

@rahul-rocket @evereq

Even the spacing and padding is way more than needed i modified html with fontsize as well and here is the result After :

image

Before:

image

posted by Gramosx over 1 year ago

@rahul-rocket @evereq Can We Impliment this kind of feature for showing no. of tags selected (Ref. Ever Teams)

https://github.com/ever-co/ever-gauzy/assets/23419372/386532fa-9965-4301-9909-b1643e0277ac

posted by Gramosx over 1 year ago

@rahul-rocket @evereq I have implemented same as gauzy teams, as showing tags was in the field was not user friendly.

Before : tags-earlier.webm

After Tags.webm

posted by Gramosx over 1 year ago

@rahul-rocket @evereq

Even the spacing and padding is way more than needed i modified html with fontsize as well and here is the result After :

image

Before:

image

@Gramosx UI looks good, please only this changes and generate PR.

posted by rahul-rocket over 1 year ago

@Gramosx / @rahul-rocket yes, I think we only need to actually make it show well values inside dropdown like Rahul did in https://github.com/ever-co/ever-gauzy/issues/5811#issuecomment-1666450795. We do NOT want to show "number" of selected items really, that's worse than show exactly values that were selected (i.e I don't want to see "items (3)"). So https://github.com/ever-co/ever-gauzy/issues/5811#issuecomment-1657068410 is not good and we will have to change it in Gauzy Teams too! The idea is that in many cases one label will be selected and it will be short enough to fit into the input box! (labels are short too, e.g. "api", "devops", "frontend" etc).

So: a) when user expands combo box, would prefer to see values in full (and if values do not fit please show "...", that's fine). b) In the input of that combo box show what values are selected (with "space" between selected items, like in some tag inputs components). We use that control already in Gauzy UI, not sure why we want to change that, see below how it already works:

image

posted by evereq over 1 year ago

@Gramosx / @rahul-rocket what was need to be fixed somehow is really this: when multiple tags are selected, and the user "enters" combo box, it should show all that is selected well (even if 10 were selected for example, just expand the combo box input temporary to show all of them before user leave input. If it's too complex to make, just show selection in one line with "..." at the end and what is not fit, it's fine, user can always scroll combobox values to see more values that were selected. In most cases it's anyway will be just one value or two...

posted by evereq over 1 year ago

Fund this Issue

$0.00
Funded

Pull requests