chalk/strip-ansi

Deprecate in favour of node:util `stripVTControlCharacters`? #53

SBoudrias posted onGitHub

Hi, now that Node has stripVTControlCharacters in the core, is there a good reason to keep using strip-ansi? (Fully supported since Node v16.11.0)

I hope this doesn't come across the wrong way! I used strip-ansi a long time and I'm thankful for it ❤️

  • Is there things strip-ansi does that's not in stripVTControlCharacters?
  • If not, for the ecosystem health, maybe you could consider adding a note on the README?

Hey again :D

Coming from https://github.com/SBoudrias/Inquirer.js/issues/1643

Node.js’s implementation of stripVTControlCharacters is based on the code from this package (see this line). From what I can tell, it’s basically this package with some internal Node.js stuff added

posted by gnify 3 months ago

We should definitely mention stripVTControlCharacters in the readme.

This packages does have some benefits though. It gets improvements faster and it also provides consistent behavior across Node.js versions.

So it doesn't make sense to deprecate the package.

posted by sindresorhus 3 months ago

We should definitely mention stripVTControlCharacters in the readme.

This packages does have some benefits though. It gets improvements faster and it also provides consistent behavior across Node.js versions.

So it doesn't make sense to deprecate the package.

First of all, thank you for your incredible contributions to open source! If it weren’t for your work and packages like this, this conversation might not even be happening. Your efforts truly shape the ecosystem, and we all deeply appreciate it. ❤️

Regarding the package's future, what do you think about adding a note to the README that the package is in a "finished" state? It would continue to receive maintenance and support, but no new features would be added. This with the mention of possibly considering stripVTControlCharacters/ or maybe README could contain some insights on Node's implementation and why people should prefer one or another.

posted by gnify 3 months ago

Fund this Issue

$0.00
Funded

Pull requests