Xaymar/obs-StreamFX

Shader: Multiple views of the same shader render the entire shader again #392

Xaymar posted onGitHub

<!-- Hi, thank you for taking the time to report a bug/crash/freeze. -->

<!-- Please make sure that you fill this out in it's entirety. -->

<!-- Unfortunately I will have to close issues if it has not been filled out. -->

Description

The addition of the prepare_render() method results in shaders rendering every render() call, instead of only once after a tick(). This means that having Studio Mode enabled, a Filter dialog open, or the source settings open, all cause additional invocations of the same exact shader. This is an unwanted extra cost and must be avoided.

<!-- Please describe the bug/crash/freeze in its entirety, including how you made this happen. -->

<!-- If you have screenshots of the broken behavior, please attach them. -->

<!-- Additionally, if you have log files, please ATTACH them. Do not paste them into this -->

System Information

<!-- Either fill out the following or attach a DxDiag file. -->

  • Software Version: master
  • Operating System: Windows
  • Kernel Version: 2004
  • CPU: AMD Zen2
  • GPU: Nvidia RTX 3xxx Series
  • RAM: 64GB

Fund this Issue

$0.00
Funded

Pull requests